Switch from Travis to GitHub Actions for CI #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis stopped building for open source in June 2021. I'm testing Ruby 2.4+ and activerecord 4.2+, using Rails's CI as a guide for which Ruby versions to test each activerecord version on. While the gemspec supports Ruby 1.8+ and activerecord 3.1+, the older Ruby versions with aren't installable on GitHub Actions, or crash, so they're not tested. Given their age, support should likely be dropped for them as compatibility will no longer be ensured if CI isn't testing them. I'm using PostgreSQL 11 as v12 and newer use a larger precision for the distance returned when using `selecting_distance_from`, which fails a spec. Ideally the spec should be updated to not assert a specific precision, allowing larger precisions. This'll highlight a regression in `selecting_distance_from` on activerecord 6.1+ when called directly on a geolocated model, as opposed to through a geolocated model, which I'll address in a follow up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis stopped building for open source in June 2021.
I'm testing Ruby 2.4+ and activerecord 4.2+, using Rails's CI as a guide for which Ruby versions to test each activerecord version on. While this gem's gemspec supports Ruby 1.8+ and activerecord 3.1+, the older Ruby versions aren't installable on GitHub Actions, or crash, so they're not tested. Given their age, support should likely be dropped for them as compatibility will no longer be ensured if CI isn't testing them.
I'm using PostgreSQL 11 as v12 and newer use a larger precision for the distance returned when using
selecting_distance_from, which fails a spec. Ideally the spec should be updated to not assert a specific precision, allowing larger precisions.This'll highlight a regression in
selecting_distance_fromon activerecord 6.1+ when called directly on a geolocated model, as opposed to through a geolocated model, which I'll address in a follow up PR.Thanks for the existing work on this gem!
Note: I suspect CI wont actually run until after this is merged, then it should run on the resulting merge commit, as well as future PRs. You can see the results of the CI run on my fork:
https://github.com/cgunther/activerecord-postgres-earthdistance/actions/runs/3254382136