Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exhaustion feature for failed retweet attemps #32

Merged
merged 4 commits into from
Apr 5, 2021
Merged

Add exhaustion feature for failed retweet attemps #32

merged 4 commits into from
Apr 5, 2021

Conversation

chez14
Copy link
Member

@chez14 chez14 commented Mar 18, 2021 •
edited
Loading

In this PR:

  • Add retweetedAt with type datetime.
  • Add failedAt with type datetime.
  • Retweet will mark both hasRetweeted and retweetedAt.
  • getApprovedTweets will now only find tweets that doesnt have retweetedAt and failedAt with approvedAt datetime is filled.
  • Docker image for Development and Production is now updated to Nodejs v14.

Will fix #28, and possibly will improve #27.

@chez14 chez14 self-assigned this Mar 18, 2021
@chez14 chez14 added dependencies Update one or more dependencies version minor Increment the minor version when merged performance Improve performance of an existing feature labels Mar 18, 2021
@chez14 chez14 force-pushed the chris/28-failed-tweets branch from 585892f to 94e182b Compare March 18, 2021 19:10
@chez14
Copy link
Member Author

chez14 commented Mar 18, 2021

Hi @Namchee,

Can you help me review this? Does this meet your coding standard?

Thanks!

@chez14 chez14 requested a review from Namchee March 18, 2021 19:10
@chez14 chez14 changed the title chore: code cleanup for unused docker-compose Add exhaustion feature for failed retweet attemps Mar 20, 2021
@Namchee Namchee self-requested a review April 5, 2021 11:31
@chez14
Copy link
Member Author

chez14 commented Apr 5, 2021

DB backed up, time to merge!

Arigathanks @Namchee!

@chez14 chez14 merged commit 55151a4 into master Apr 5, 2021
@chez14 chez14 deleted the chris/28-failed-tweets branch April 5, 2021 11:37
@repurika
Copy link
Collaborator

repurika commented Apr 5, 2021

🚀 PR was released in v0.3.0 🚀

@repurika repurika added the released This issue/pull request has been released. label Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Namchee Namchee Namchee approved these changes

Assignees

@chez14 chez14

Labels
dependencies Update one or more dependencies version minor Increment the minor version when merged performance Improve performance of an existing feature released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed Tweets is always retried with no exhaustion limit
3 participants
@chez14 @repurika @Namchee