Fix suppressing embeds on messages with webhooks #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
referenced
this pull request
in SvenKirschbaum/musikbot-client
Mar 17, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | debian | final | digest | `d02c76d` -> `ccb33c3` | | | | | | maven | stage | digest | `163c984` -> `2b884f2` | | | | | | rust | stage | digest | `a71cd88` -> `d36f9d8` | | | | | | [net.dv8tion:JDA](https://togithub.com/DV8FromTheWorld/JDA) | compile | patch | `5.0.0-beta.20` -> `5.0.0-beta.21` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>DV8FromTheWorld/JDA (net.dv8tion:JDA)</summary> ### [`v5.0.0-beta.21`](https://togithub.com/discord-jda/JDA/releases/tag/v5.0.0-beta.21): | Bug fixes and enforced nonce on messages ### Overview This release fixes a few bugs but also implements a new behavior on message sending. With the new [enforce nonce](https://discord.com/developers/docs/change-log#enforced-nonces-on-create-message-endpoint) behavior, messages will no longer be duplicated due to timeouts or discord outages. This means, any message request will now send an automatically generated [nonce](https://en.wikipedia.org/wiki/Cryptographic_nonce). You can still set a custom nonce using [setNonce](https://docs.jda.wiki/net/dv8tion/jda/api/requests/restaction/MessageCreateAction.html#setNonce\(java.lang.String\)), but you should make sure that this nonce is **unique**. If you previously relied on this setter, ensure that you are not sending duplicated nonce values. #### New Features - Add DiscordLocale values for these locales: Indonesian and Latin America (Spanish LATAM) by [@​stackpan](https://togithub.com/stackpan) in [https://github.com/discord-jda/JDA/pull/2627](https://togithub.com/discord-jda/JDA/pull/2627) #### Changes - Add support for enforce_nonce by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2614](https://togithub.com/discord-jda/JDA/pull/2614) #### Bug Fixes - Add missing generic type to shardmanager by [@​duncte123](https://togithub.com/duncte123) in [https://github.com/discord-jda/JDA/pull/2612](https://togithub.com/discord-jda/JDA/pull/2612) - Add missing proxy url field to the MessageEmbed.VideoInfo class by [@​shaksternano](https://togithub.com/shaksternano) in [https://github.com/discord-jda/JDA/pull/2618](https://togithub.com/discord-jda/JDA/pull/2618) - Fix suppressing embeds on messages with webhooks by [@​freya022](https://togithub.com/freya022) in [https://github.com/discord-jda/JDA/pull/2620](https://togithub.com/discord-jda/JDA/pull/2620) **Full Changelog**: discord-jda/JDA@v5.0.0-beta.20...v5.0.0-beta.21 ### Installation #### Gradle ```gradle repositories { mavenCentral() } dependencies { implementation("net.dv8tion:JDA:5.0.0-beta.21") } ``` #### Maven ```xml <dependency> <groupId>net.dv8tion</groupId> <artifactId>JDA</artifactId> <version>5.0.0-beta.21</version> </dependency> ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on sunday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/musikbot-client).
](https://renovatebot.com){kind=link}
This was referenced Aug 4, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This used to delete the message instead of editing the flags