New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update target and focus behavior #14

Open

mzlock wants to merge 2 commits into main from update-focus-behavior

+1,050 −29

Contributor

mzlock commented May 16, 2023

updates the targeting and focus utils to include some changes made to another copy
- use promises and await when getting new prev/next drop targets
- FocusManager can take a getActiveElement option
removes this.actions.publishDragSource() in handleDragStart -- this seemed to be publishing an old copy of the drag source, which caused some positioning issues when an item was dragged more than once

mzlock added 2 commits

May 15, 2023 15:01


          update some focus behavior

3b7aba1


          remove publish source

cd7acee

mzlock requested a review from faultyserver

May 16, 2023 14:33

mzlock marked this pull request as ready for review

May 16, 2023 14:33

Contributor Author

mzlock commented Sep 29, 2023

Will come back to this work soon. I still need to:

remove yarn stuff, since this uses pnpm now
double-check that removing this.actions.publishDragSource(); won't break things for other apps using the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet