Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Message): add more attachment flags and fields #1197

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Jan 22, 2025

Please describe the changes this PR makes and why it should be merged:

  • completes attachment flags enum
  • adds embed flags and embed media flags
  • adds attachment clip fields

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 8:12pm

/**
* For Clips, array of users who were in the stream
*/
clip_participants?: APIUser[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure that for endpoints that can post attachments, this won't cause issues 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those use

export type RESTAPIAttachment = Partial<
Pick<APIAttachment, 'description' | 'duration_secs' | 'filename' | 'title' | 'waveform'>
> & {
/**
* Attachment id or a number that matches `n` in `files[n]`
*/
id: Snowflake | number;
};

so they should not be affected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants