Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implemented MultiReader #68

Merged

Conversation

fernandoGubiMarques
Copy link
Collaborator

Describe your changes

Implemented a reader class to compile the output of multiple readers.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests to this funtionality.
  • All tests are passing.
  • I have updated the documentation as needed.
  • I have followed the project's coding guidelines.

@GabrielBG0 GabrielBG0 self-requested a review July 3, 2024 19:04
@GabrielBG0 GabrielBG0 self-assigned this Jul 3, 2024
@GabrielBG0
Copy link
Collaborator

@fernandoGubiMarques How do you think this new reader could be used and why do you think it is important for us to have it?

@fernandoGubiMarques
Copy link
Collaborator Author

This class is crucial for reading from more than one source which contain homologous information. For example, in the context of seismic segmentation, two seismic attributes for the same patch of subsoil stored in separate .npy files can be read from using PatchedArrayReader, but their items remain disconnected.

Through this composite reader, the i-th item of each of the PatchedArrayReaders stacked together according to a collate_fn function."""

@GabrielBG0
Copy link
Collaborator

sure

Copy link
Collaborator

@GabrielBG0 GabrielBG0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GabrielBG0 GabrielBG0 merged commit 2ee6e8c into discovery-unicamp:main Jul 4, 2024
1 check passed
@fernandoGubiMarques fernandoGubiMarques deleted the deeplab-pretext branch July 5, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants