Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting Typing #69

Merged

Conversation

GabrielBG0
Copy link
Collaborator

Correct typing for python 3.8 support and for correctness

@GabrielBG0 GabrielBG0 requested a review from otavioon July 4, 2024 13:46
Copy link
Collaborator

@otavioon otavioon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes

minerva/models/nets/time_series/cnns.py Outdated Show resolved Hide resolved
minerva/pipelines/base.py Outdated Show resolved Hide resolved
minerva/pipelines/base.py Outdated Show resolved Hide resolved
minerva/pipelines/lightning_pipeline.py Outdated Show resolved Hide resolved
minerva/pipelines/lightning_pipeline.py Outdated Show resolved Hide resolved
@GabrielBG0 GabrielBG0 requested a review from otavioon July 5, 2024 02:24
Copy link
Collaborator

@otavioon otavioon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@otavioon otavioon merged commit e26a2f1 into discovery-unicamp:main Jul 5, 2024
1 check passed
@GabrielBG0 GabrielBG0 deleted the correct-optional-variables branch July 5, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants