remove useless logger for httpserver.VerifyRequest

disgoorg · Jun 10, 2022 · c706efb · c706efb
1 parent e527a8f
commit c706efb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/httpserver/server.go b/httpserver/server.go
@@ -39,7 +39,7 @@ type Server interface {
 
 // VerifyRequest implements the verification side of the discord interactions api signing algorithm, as documented here: https://discord.com/developers/docs/interactions/slash-commands#security-and-authorization
 // Credit: https://github.com/bsdlp/discord-interactions-go/blob/main/interactions/verify.go
-func VerifyRequest(logger log.Logger, r *http.Request, key PublicKey) bool {
+func VerifyRequest(r *http.Request, key PublicKey) bool {
 	var msg bytes.Buffer
 
 	signature := r.Header.Get("X-Signature-Ed25519")
@@ -64,10 +64,7 @@ func VerifyRequest(logger log.Logger, r *http.Request, key PublicKey) bool {
 	msg.WriteString(timestamp)
 
 	defer func() {
-		err = r.Body.Close()
-		if err != nil {
-			logger.Error("error while closing request body: ", err)
-		}
+		_ = r.Body.Close()
 	}()
 	var body bytes.Buffer
 

diff --git a/httpserver/server_impl.go b/httpserver/server_impl.go
@@ -88,7 +88,7 @@ const (
 )
 
 func (h *WebhookInteractionHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
-	if ok := VerifyRequest(h.server.Logger(), r, h.server.PublicKey()); !ok {
+	if ok := VerifyRequest(r, h.server.PublicKey()); !ok {
 		w.WriteHeader(http.StatusUnauthorized)
 		data, _ := io.ReadAll(r.Body)
 		h.server.Logger().Trace("received http interaction with invalid signature. body: ", string(data))