Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: disgo consts - composed #367

Closed
wants to merge 1 commit into from
Closed

enhance: disgo consts - composed #367

wants to merge 1 commit into from

Conversation

Malix-Labs
Copy link
Contributor

This is me being very autistic

@Malix-Labs Malix-Labs changed the title enhance: disgo.go composed const enhance: disgo consts - composed Jun 24, 2024
topi314
topi314 reviewed Jun 24, 2024
View reviewed changes
Copy link
Member

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with this change since the go module, git url & library name are not necessarily connected together. go modules can be served via a custom domain as an example which I might intend in the future.

Keeping them as is makes the most sense imo

@Malix-Labs
Copy link
Contributor Author

Understandable

@Malix-Labs Malix-Labs closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topi314 topi314 topi314 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Malix-Labs @topi314