Add shutdown timeout #39
Conversation
| @@ -42,11 +43,11 @@ object Main extends IOApp.Simple { | |||
| .withPort(thePort) | |||
| .withHost(theHost) | |||
| .withHttpApp(routes.orNotFound) | |||
| .withShutdownTimeout(1.second) | |||
There was a problem hiding this comment.
suggestion: You can even set it to zero :)
| .build | ||
| .productL(IO.println(message).toResource) | ||
| } | ||
| .useForever | ||
| .race(IO.readLine) | ||
| .surround(IO.readLine) |
There was a problem hiding this comment.
thought: slight change of semantics, this makes it so that you can only cancel with a readLine once the resource has been allocated. Previously, if the resource is cancelable, you could prevent the server from even starting. I'm not sure if it matters for Ember though.
yes that's super annoying, but I don't understand why it takes 30 seconds to shutdown a server that has no outstanding connections (or maybe one?), there must be an issue |
|
QQ, are you ever seeing this before making requests? I saw these shutdowns taking lots of time after I'd made requests from the browser, but closing the browser would kill any outstanding connections and IIRC it would help. |
I can't recall if it was happening after an interaction w/ the browser or not, I'll try to see |
Otherwise it may take up to 30 seconds for it to stop after pressing enter.