Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relevant files to scala-steward config #43

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

daddykotex
Copy link
Contributor

This will avoid that our contributors have to spend time on things like: #42

This will avoid that our contributors have to spend time on
things like: #42
@valencik
Copy link
Contributor

valencik commented Dec 15, 2023

In my experience this only works if your outer build also has the libraries of the inner build.

In typelevel.g8 we list all the inner dependencies in the outer build so they get steward updates:
https://github.com/typelevel/typelevel.g8/blob/main/build.sbt#L38-L48

@valencik
Copy link
Contributor

Ahh, here's the reference I was trying to find:
scala-steward-org/scala-steward#1286 (comment)

@daddykotex
Copy link
Contributor Author

oh thank you so much
I was thinking that the updates we were getting meant it was working, but we only got updates for the outer build (sbt, scalafmt)

nothing from the inner builds (even when the path were valid)

I'll address it
thanks

@daddykotex daddykotex marked this pull request as draft December 15, 2023 19:05
@daddykotex daddykotex marked this pull request as ready for review December 18, 2023 14:52
@daddykotex daddykotex merged commit 6fc2107 into main Dec 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants