Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
dhpiggott authored Aug 8, 2023
1 parent b60496d commit 83d6d3c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,13 @@ private[smithy4s] class UrlFormDataDecoderSchemaVisitor(

case UrlFormCursor(history, values) =>
// Collection members aren't necessarily primitives, and if they
// aren't, then there will be multiple pathed values for the same
// aren't, then there will be multiple values for the same
// index. One example is maps, which are encoded as collections of
// structs, e.g.
// foos.entry.1.key=a&foos.entry.1.value=1&foos.entry.2.key=b&foos.entry.2.value=2.
// That's why we have to group by index.
//
// We can't assume they were encoding in order. That's why we have to
// We can't assume they were encoded in order. That's why we have to
// then sort by index.
val groupedAndSortedCursors = values
.collect {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ private[smithy4s] class UrlFormDataEncoderSchemaVisitor(
): UrlFormDataEncoder[P] =
Primitive.stringWriter(tag, hints) match {
case Some(writer) =>
p => List(UrlForm.FormData(PayloadPath.root, Some(writer(p))))
primitive => List(UrlForm.FormData(PayloadPath.root, Some(writer(primitive))))

case None =>
_ => Nil
Expand Down

0 comments on commit 83d6d3c

Please sign in to comment.