Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(0.19) Remove optics settings from build tools #1537

Closed
kubukoz opened this issue May 23, 2024 · 1 comment
Closed

(0.19) Remove optics settings from build tools #1537

kubukoz opened this issue May 23, 2024 · 1 comment
Labels
good first issue Good for newcomers
Milestone

Comments

@kubukoz
Copy link
Member

kubukoz commented May 23, 2024

https://disneystreaming.github.io/smithy4s/docs/codegen/customisation/optics/

If you're using Smithy4s via mill or sbt, then you can enable this functionality with the following keys:

    in mill, task: def smithy4sRenderOptics = true
    in sbt, setting: smithy4sRenderOptics := true

Citing @Baccata, we don't want to maintain such configuration on the build tool level, it should rather be configurable via Smithy metadata in additional Smithy source files.

In this case, it already is:

metadata smithy4sRenderOptics = true

so it should be a straightforward removal.

This will possibly break existing usage, so it should target the series/0.19 branch.

@kubukoz kubukoz added this to the 0.19.0 milestone May 23, 2024
@kubukoz kubukoz added the good first issue Good for newcomers label May 23, 2024
@kubukoz
Copy link
Member Author

kubukoz commented Oct 30, 2024

done in #1566

@kubukoz kubukoz closed this as completed Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant