-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove smithy4sRenderOptics setting from plugins #1566
remove smithy4sRenderOptics setting from plugins #1566
Conversation
Do we still have tests that utilize the optics being generated conditionally? |
I thought so , I will verify |
Confirmed, we have:
so I think we're good. |
@@ -278,7 +272,6 @@ object Smithy4sCodegenPlugin extends AutoPlugin { | |||
file, | |||
s"""$$version: "2" | |||
|metadata smithy4sWildcardArgument = "$wildcardArg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: I would consider dropping smithy4sWildcardArgument
too, we should use *
and ask people to enable -Xsource:3
or -Xsource:3-cross
.
and the corresponding sbt-test module
closes #1537
PR Checklist (not all items are relevant to all PRs)