-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire up EC2 Query codec based on Query codec, plus compliance tests #1120
Merged
daddykotex
merged 26 commits into
disneystreaming:series/0.18
from
dhpiggott:ec2-query-support
Aug 2, 2023
Merged
Wire up EC2 Query codec based on Query codec, plus compliance tests #1120
daddykotex
merged 26 commits into
disneystreaming:series/0.18
from
dhpiggott:ec2-query-support
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baccata
reviewed
Jul 27, 2023
dhpiggott
commented
Jul 27, 2023
Baccata
reviewed
Jul 27, 2023
modules/aws-http4s/src/smithy4s/aws/internals/AwsEc2QueryCodecs.scala
Outdated
Show resolved
Hide resolved
Verified with ~aws-http4s/testOnly smithy4s.aws.AwsComplianceSuite -- -o *Response*
The previous approach was trying to transform member names as a pre-processing step. It could have worked but was getting unwieldy and hard to reason about, and still hadn't covered all cases. Much simpler to have the member name transformation happen conditionally within the existing encoder SchemaVisitor.
Also refine hint transformer to work with member hints specifically, per the spec.
Codegen is failing with a bunch of errors like this: ... ... ... [WARNING] com.amazonaws.ec2#ResourceType$prefix_list: The name `prefix_list` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58444:5 [WARNING] com.amazonaws.ec2#ResourceType$replace_root_volume_task: The name `replace_root_volume_task` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58445:5 [WARNING] com.amazonaws.ec2#ResourceType$reserved_instances: The name `reserved_instances` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58446:5 [WARNING] com.amazonaws.ec2#ResourceType$route_table: The name `route_table` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58447:5 [WARNING] com.amazonaws.ec2#ResourceType$security_group: The name `security_group` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58448:5 [WARNING] com.amazonaws.ec2#ResourceType$security_group_rule: The name `security_group_rule` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58449:5 [WARNING] com.amazonaws.ec2#ResourceType$snapshot: The name `snapshot` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58450:5 [WARNING] com.amazonaws.ec2#ResourceType$spot_fleet_request: The name `spot_fleet_request` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58451:5 [WARNING] com.amazonaws.ec2#ResourceType$spot_instances_request: The name `spot_instances_request` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58452:5 [WARNING] com.amazonaws.ec2#ResourceType$subnet: The name `subnet` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58453:5 [WARNING] com.amazonaws.ec2#ResourceType$subnet_cidr_reservation: The name `subnet_cidr_reservation` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58454:5 [WARNING] com.amazonaws.ec2#ResourceType$traffic_mirror_filter: The name `traffic_mirror_filter` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58455:5 [WARNING] com.amazonaws.ec2#ResourceType$traffic_mirror_filter_rule: The name `traffic_mirror_filter_rule` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58476:5 [WARNING] com.amazonaws.ec2#ResourceType$traffic_mirror_session: The name `traffic_mirror_session` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58456:5 [WARNING] com.amazonaws.ec2#ResourceType$traffic_mirror_target: The name `traffic_mirror_target` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58457:5 [WARNING] com.amazonaws.ec2#ResourceType$transit_gateway: The name `transit_gateway` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58458:5 [WARNING] com.amazonaws.ec2#ResourceType$transit_gateway_attachment: The name `transit_gateway_attachment` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58459:5 [WARNING] com.amazonaws.ec2#ResourceType$transit_gateway_connect_peer: The name `transit_gateway_connect_peer` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58460:5 [WARNING] com.amazonaws.ec2#ResourceType$transit_gateway_multicast_domain: The name `transit_gateway_multicast_domain` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58461:5 [WARNING] com.amazonaws.ec2#ResourceType$transit_gateway_policy_table: The name `transit_gateway_policy_table` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58462:5 [WARNING] com.amazonaws.ec2#ResourceType$transit_gateway_route_table: The name `transit_gateway_route_table` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58463:5 [WARNING] com.amazonaws.ec2#ResourceType$transit_gateway_route_table_announcement: The name `transit_gateway_route_table_announcement` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58464:5 [WARNING] com.amazonaws.ec2#ResourceType$verified_access_endpoint: The name `verified_access_endpoint` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58480:5 [WARNING] com.amazonaws.ec2#ResourceType$verified_access_group: The name `verified_access_group` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58479:5 [WARNING] com.amazonaws.ec2#ResourceType$verified_access_instance: The name `verified_access_instance` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58478:5 [WARNING] com.amazonaws.ec2#ResourceType$verified_access_policy: The name `verified_access_policy` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58481:5 [WARNING] com.amazonaws.ec2#ResourceType$verified_access_trust_provider: The name `verified_access_trust_provider` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58482:5 [WARNING] com.amazonaws.ec2#ResourceType$volume: The name `volume` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58465:5 [WARNING] com.amazonaws.ec2#ResourceType$vpc: The name `vpc` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58466:5 [WARNING] com.amazonaws.ec2#ResourceType$vpc_block_public_access_exclusion: The name `vpc_block_public_access_exclusion` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58484:5 [WARNING] com.amazonaws.ec2#ResourceType$vpc_endpoint: The name `vpc_endpoint` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58467:5 [WARNING] com.amazonaws.ec2#ResourceType$vpc_endpoint_connection: The name `vpc_endpoint_connection` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58468:5 [WARNING] com.amazonaws.ec2#ResourceType$vpc_endpoint_connection_device_type: The name `vpc_endpoint_connection_device_type` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58477:5 [WARNING] com.amazonaws.ec2#ResourceType$vpc_endpoint_service: The name `vpc_endpoint_service` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58469:5 [WARNING] com.amazonaws.ec2#ResourceType$vpc_endpoint_service_permission: The name `vpc_endpoint_service_permission` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58470:5 [WARNING] com.amazonaws.ec2#ResourceType$vpc_flow_log: The name `vpc_flow_log` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58474:5 [WARNING] com.amazonaws.ec2#ResourceType$vpc_peering_connection: The name `vpc_peering_connection` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58471:5 [WARNING] com.amazonaws.ec2#ResourceType$vpn_connection: The name `vpn_connection` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58472:5 [WARNING] com.amazonaws.ec2#ResourceType$vpn_connection_device_type: The name `vpn_connection_device_type` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58483:5 [WARNING] com.amazonaws.ec2#ResourceType$vpn_gateway: The name `vpn_gateway` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58473:5 [WARNING] com.amazonaws.ec2#ResultRange: Error validating @default trait: Value provided for `com.amazonaws.ec2#ResultRange` must be greater than or equal to 20, but found 0 | DefaultTrait.Target jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58491:1 [WARNING] com.amazonaws.ec2#RootDeviceType$ebs: The name `ebs` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58517:5 [WARNING] com.amazonaws.ec2#RootDeviceType$instance_store: The name `instance_store` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58518:5 [WARNING] com.amazonaws.ec2#RouteOrigin$CreateRoute: The name `CreateRoute` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58525:5 [WARNING] com.amazonaws.ec2#RouteOrigin$CreateRouteTable: The name `CreateRouteTable` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58524:5 [WARNING] com.amazonaws.ec2#RouteOrigin$EnableVgwRoutePropagation: The name `EnableVgwRoutePropagation` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58526:5 [WARNING] com.amazonaws.ec2#RouteState$active: The name `active` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58530:5 [WARNING] com.amazonaws.ec2#RouteState$blackhole: The name `blackhole` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58531:5 [WARNING] com.amazonaws.ec2#RouteTableAssociationStateCode$associated: The name `associated` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58538:5 [WARNING] com.amazonaws.ec2#RouteTableAssociationStateCode$associating: The name `associating` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58537:5 [WARNING] com.amazonaws.ec2#RouteTableAssociationStateCode$disassociated: The name `disassociated` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58540:5 [WARNING] com.amazonaws.ec2#RouteTableAssociationStateCode$disassociating: The name `disassociating` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58539:5 [WARNING] com.amazonaws.ec2#RouteTableAssociationStateCode$failed: The name `failed` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58541:5 [WARNING] com.amazonaws.ec2#RuleAction$allow: The name `allow` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58547:5 [WARNING] com.amazonaws.ec2#RuleAction$deny: The name `deny` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58548:5 [WARNING] com.amazonaws.ec2#SearchTransitGatewayMulticastGroupsRequest$MaxResults: Error validating @default trait: Value provided for `com.amazonaws.ec2#TransitGatewayMaxResults` must be greater than or equal to 5, but found 0 | DefaultTrait.Target jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:46791:44 [WARNING] com.amazonaws.ec2#SearchTransitGatewayRoutesRequest$MaxResults: Error validating @default trait: Value provided for `com.amazonaws.ec2#TransitGatewayMaxResults` must be greater than or equal to 5, but found 0 | DefaultTrait.Target jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:46870:44 [WARNING] com.amazonaws.ec2#SelfServicePortal$disabled: The name `disabled` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58569:5 [WARNING] com.amazonaws.ec2#SelfServicePortal$enabled: The name `enabled` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58568:5 [WARNING] com.amazonaws.ec2#ServiceConnectivityType$ipv4: The name `ipv4` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58576:5 [WARNING] com.amazonaws.ec2#ServiceConnectivityType$ipv6: The name `ipv6` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58577:5 [WARNING] com.amazonaws.ec2#ServiceState$Available: The name `Available` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58582:5 [WARNING] com.amazonaws.ec2#ServiceState$Deleted: The name `Deleted` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58584:5 [WARNING] com.amazonaws.ec2#ServiceState$Deleting: The name `Deleting` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58583:5 [WARNING] com.amazonaws.ec2#ServiceState$Failed: The name `Failed` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58585:5 [WARNING] com.amazonaws.ec2#ServiceState$Pending: The name `Pending` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58581:5 [WARNING] com.amazonaws.ec2#ServiceType$Gateway: The name `Gateway` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58590:5 [WARNING] com.amazonaws.ec2#ServiceType$GatewayLoadBalancer: The name `GatewayLoadBalancer` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58591:5 [WARNING] com.amazonaws.ec2#ServiceType$Interface: The name `Interface` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58589:5 [WARNING] com.amazonaws.ec2#ShutdownBehavior$stop: The name `stop` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58595:5 [WARNING] com.amazonaws.ec2#ShutdownBehavior$terminate: The name `terminate` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58596:5 [WARNING] com.amazonaws.ec2#SnapshotAttributeName$createVolumePermission: The name `createVolumePermission` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58601:5 [WARNING] com.amazonaws.ec2#SnapshotAttributeName$productCodes: The name `productCodes` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58600:5 [WARNING] com.amazonaws.ec2#SnapshotState$completed: The name `completed` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58608:5 [WARNING] com.amazonaws.ec2#SnapshotState$error: The name `error` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58609:5 [WARNING] com.amazonaws.ec2#SnapshotState$pending: The name `pending` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58607:5 [WARNING] com.amazonaws.ec2#SnapshotState$recoverable: The name `recoverable` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58610:5 [WARNING] com.amazonaws.ec2#SnapshotState$recovering: The name `recovering` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58611:5 [WARNING] com.amazonaws.ec2#SpotInstanceInterruptionBehavior$hibernate: The name `hibernate` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58625:5 [WARNING] com.amazonaws.ec2#SpotInstanceInterruptionBehavior$stop: The name `stop` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58626:5 [WARNING] com.amazonaws.ec2#SpotInstanceInterruptionBehavior$terminate: The name `terminate` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58627:5 [WARNING] com.amazonaws.ec2#SpotInstanceState$active: The name `active` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58634:5 [WARNING] com.amazonaws.ec2#SpotInstanceState$cancelled: The name `cancelled` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58636:5 [WARNING] com.amazonaws.ec2#SpotInstanceState$closed: The name `closed` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58635:5 [WARNING] com.amazonaws.ec2#SpotInstanceState$failed: The name `failed` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58637:5 [WARNING] com.amazonaws.ec2#SpotInstanceState$open: The name `open` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58633:5 [WARNING] com.amazonaws.ec2#SpotInstanceType$one_time: The name `one_time` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58641:5 [WARNING] com.amazonaws.ec2#SpotInstanceType$persistent: The name `persistent` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58642:5 [WARNING] com.amazonaws.ec2#SpotPlacementScoresMaxResults: Error validating @default trait: Value provided for `com.amazonaws.ec2#SpotPlacementScoresMaxResults` must be greater than or equal to 10, but found 0 | DefaultTrait.Target jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58645:1 [WARNING] com.amazonaws.ec2#SpotPlacementScoresTargetCapacity: Error validating @default trait: Value provided for `com.amazonaws.ec2#SpotPlacementScoresTargetCapacity` must be greater than or equal to 1, but found 0 | DefaultTrait.Target jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58652:1 [WARNING] com.amazonaws.ec2#SpreadLevel$host: The name `host` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58660:5 [WARNING] com.amazonaws.ec2#SpreadLevel$rack: The name `rack` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58661:5 [WARNING] com.amazonaws.ec2#State$Available: The name `Available` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58667:5 [WARNING] com.amazonaws.ec2#State$Deleted: The name `Deleted` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58669:5 [WARNING] com.amazonaws.ec2#State$Deleting: The name `Deleting` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58668:5 [WARNING] com.amazonaws.ec2#State$Expired: The name `Expired` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58672:5 [WARNING] com.amazonaws.ec2#State$Failed: The name `Failed` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58671:5 [WARNING] com.amazonaws.ec2#State$Pending: The name `Pending` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58666:5 [WARNING] com.amazonaws.ec2#State$PendingAcceptance: The name `PendingAcceptance` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58665:5 [WARNING] com.amazonaws.ec2#State$Rejected: The name `Rejected` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58670:5 [WARNING] com.amazonaws.ec2#StaticSourcesSupportValue$disable: The name `disable` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58677:5 [WARNING] com.amazonaws.ec2#StaticSourcesSupportValue$enable: The name `enable` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58676:5 [WARNING] com.amazonaws.ec2#StatisticType$p50: The name `p50` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58681:5 [WARNING] com.amazonaws.ec2#Status$inClassic: The name `inClassic` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58687:5 [WARNING] com.amazonaws.ec2#Status$inVpc: The name `inVpc` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58686:5 [WARNING] com.amazonaws.ec2#Status$moveInProgress: The name `moveInProgress` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58685:5 [WARNING] com.amazonaws.ec2#StatusName$reachability: The name `reachability` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58691:5 [WARNING] com.amazonaws.ec2#StatusType$failed: The name `failed` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58696:5 [WARNING] com.amazonaws.ec2#StatusType$initializing: The name `initializing` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58698:5 [WARNING] com.amazonaws.ec2#StatusType$insufficient_data: The name `insufficient_data` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58697:5 [WARNING] com.amazonaws.ec2#StatusType$passed: The name `passed` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58695:5 [WARNING] com.amazonaws.ec2#StorageTier$archive: The name `archive` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58702:5 [WARNING] com.amazonaws.ec2#StorageTier$standard: The name `standard` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58703:5 [WARNING] com.amazonaws.ec2#SubnetCidrBlockStateCode$associated: The name `associated` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58718:5 [WARNING] com.amazonaws.ec2#SubnetCidrBlockStateCode$associating: The name `associating` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58717:5 [WARNING] com.amazonaws.ec2#SubnetCidrBlockStateCode$disassociated: The name `disassociated` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58720:5 [WARNING] com.amazonaws.ec2#SubnetCidrBlockStateCode$disassociating: The name `disassociating` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58719:5 [WARNING] com.amazonaws.ec2#SubnetCidrBlockStateCode$failed: The name `failed` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58722:5 [WARNING] com.amazonaws.ec2#SubnetCidrBlockStateCode$failing: The name `failing` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58721:5 [WARNING] com.amazonaws.ec2#SubnetCidrReservationType$explicit: The name `explicit` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58729:5 [WARNING] com.amazonaws.ec2#SubnetCidrReservationType$prefix: The name `prefix` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58728:5 [WARNING] com.amazonaws.ec2#SubnetState$available: The name `available` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58736:5 [WARNING] com.amazonaws.ec2#SubnetState$pending: The name `pending` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58735:5 [WARNING] com.amazonaws.ec2#SummaryStatus$impaired: The name `impaired` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58741:5 [WARNING] com.amazonaws.ec2#SummaryStatus$initializing: The name `initializing` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58744:5 [WARNING] com.amazonaws.ec2#SummaryStatus$insufficient_data: The name `insufficient_data` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58742:5 [WARNING] com.amazonaws.ec2#SummaryStatus$not_applicable: The name `not_applicable` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58743:5 [WARNING] com.amazonaws.ec2#SummaryStatus$ok: The name `ok` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58740:5 [WARNING] com.amazonaws.ec2#TargetStorageTier$archive: The name `archive` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58756:5 [WARNING] com.amazonaws.ec2#Tenancy$dedicated: The name `dedicated` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58766:5 [WARNING] com.amazonaws.ec2#Tenancy$default: The name `default` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58765:5 [WARNING] com.amazonaws.ec2#Tenancy$host: The name `host` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58767:5 [WARNING] com.amazonaws.ec2#TieringOperationStatus$archival_completed: The name `archival_completed` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58774:5 [WARNING] com.amazonaws.ec2#TieringOperationStatus$archival_failed: The name `archival_failed` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58775:5 [WARNING] com.amazonaws.ec2#TieringOperationStatus$archival_in_progress: The name `archival_in_progress` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58773:5 [WARNING] com.amazonaws.ec2#TieringOperationStatus$permanent_restore_completed: The name `permanent_restore_completed` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58780:5 [WARNING] com.amazonaws.ec2#TieringOperationStatus$permanent_restore_failed: The name `permanent_restore_failed` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58781:5 [WARNING] com.amazonaws.ec2#TieringOperationStatus$permanent_restore_in_progress: The name `permanent_restore_in_progress` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58779:5 [WARNING] com.amazonaws.ec2#TieringOperationStatus$temporary_restore_completed: The name `temporary_restore_completed` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58777:5 [WARNING] com.amazonaws.ec2#TieringOperationStatus$temporary_restore_failed: The name `temporary_restore_failed` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58778:5 [WARNING] com.amazonaws.ec2#TieringOperationStatus$temporary_restore_in_progress: The name `temporary_restore_in_progress` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58776:5 [WARNING] com.amazonaws.ec2#TpmSupportValues$v2_0: The name `v2_0` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58789:5 [WARNING] com.amazonaws.ec2#TrafficDirection$egress: The name `egress` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/disneystreaming/smithy/aws-ec2-spec/2023.02.10/aws-ec2-spec-2023.02.10.jar!/META-INF/smithy/ec2.smithy:58794:5 [WARNING] com.amazonaws.ec2#TrafficDirection$ingress: The name `ingress` does not match the recommended enum name format of beginning with an uppercase letter, followed by any number of uppercase letters, numbers, or underscores. | EnumShape jar:file:///Users/david.piggott/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/di…
Thanks Oli for the patch. Also fix Sandbox compile errors. Now to overcome this: sbt:root> ~sandbox/run [info] [sandbox] compiling 2995 Scala sources to /Users/david.piggott/Code/personal/disneystreaming/smithy4s/modules/sandbox/target/jvm-2.13/classes ... [error] [sandbox] /Users/david.piggott/Code/personal/disneystreaming/smithy4s/modules/sandbox/target/jvm-2.13/src_managed/main/com/amazonaws/ec2/CreateFlowLogsRequest.scala:108:104: possible missing interpolator: detected an interpolated expression [error] [sandbox] string.optional[CreateFlowLogsRequest]("LogFormat", _.logFormat).addHints(smithy.api.Documentation("<p>The fields to include in the flow log record. List the fields in the order in which\n they should appear. If you omit this parameter, the flow log is created using the\n default format. If you specify this parameter, you must include at least one\n field. For more information about the available fields, see <a href=\"https://docs.aws.amazon.com/vpc/latest/userguide/flow-logs.html#flow-log-records\">Flow log\n records</a> in the <i>Amazon VPC User Guide</i> or <a href=\"https://docs.aws.amazon.com/vpc/latest/tgw/tgw-flow-logs.html#flow-log-records\">Transit Gateway Flow Log\n records</a> in the <i>Amazon Web Services Transit Gateway Guide</i>.</p>\n <p>Specify the fields using the <code>${field-id}</code> format, separated by spaces. For\n the CLI, surround this parameter value with single quotes on Linux or\n double quotes on Windows.</p>")),
This fixes the error described in the previous commit message.
Without this, Sandbox runs fail with the following: [error] HttpPayloadError(.DescribeInstancesResponse.reservationSet.item.0.instancesSet.item.0.placement.partitionNumber, expected = , message=Expected a single node with text content) This is because in https://raw.githubusercontent.com/aws/aws-sdk-js-v3/main/codegen/sdk-codegen/aws-models/ec2.json PartitionNumber members are defined like this: "PartitionNumber": { "target": "com.amazonaws.ec2#Integer", "traits": { "aws.protocols#ec2QueryName": "PartitionNumber", "smithy.api#clientOptional": {}, "smithy.api#default": 0, "smithy.api#documentation": "<p>The number of the partition the instance should launch in. Valid only if the placement\n group strategy is set to <code>partition</code>.</p>", "smithy.api#xmlName": "partitionNumber" } }
The EC2 spec in https://github.com/disneystreaming/aws-sdk-smithy-specs/releases/tag/v2023.02.10 doesn't contain some enum values that were retured in the describe instances response, and because at present smithy4s doesn't support open enums, decoding was failing. In time it should support open enums, but for now we can get a successful Sandbox run against the EC2 API by just using an endpoint that doesn't (at present) return unknown enum values.
daddykotex
reviewed
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job
mostly minor comments, one important bit related to checking for empty list,
modules/aws-http4s/src/smithy4s/aws/internals/AwsEc2QueryCodecs.scala
Outdated
Show resolved
Hide resolved
…s.scala Co-authored-by: David Francoeur <[email protected]>
daddykotex
approved these changes
Aug 1, 2023
lewisjkl
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach:
The compliance tests caught a few issues, fixes for which are included. I then used it in the sandbox module to call some EC2 APIs, and that found a few more issues, fixes for which are also included. The remaining issue not fixed in this PR is the need for optional open enum support. We're agree that's out of scope for this PR. The consequence is that there are a decent number of EC2 API responses which fail to decode due to AWS including enum values that are not present in the published spec. To get a good sandbox run for now I just used an EC2 endpoint that happens to not include any unknown enum values.
Summary of changes:
UrlFormDataEncoderSchemaVisitor
so it can accomodate the quirks of the AWS EC2 protocol without having to be aware of all the details. Instead, the relevant hints on the schema are transformed so thatUrlFormDataEncoderSchemaVisitor
can work only in terms ofXmlName
.AwsStandardTypesTransformer
to fix codgen error (thanks Oli for the patch).<p>Specify the fields using the <code>${field-id}</code> format, separated by spaces.
in it.XmlDecoder
aware of default hint on structure members. Without this, sandbox runs failed withHttpPayloadError(.DescribeInstancesResponse.reservationSet.item.0.instancesSet.item.0.placement.partitionNumber, expected = , message=Expected a single node with text content)
due to the use of@default
inhttps://raw.githubusercontent.com/aws/aws-sdk-js-v3/main/codegen/sdk-codegen/aws-models/ec2.json.
Merging:
Like #1112 and for the same reason, let's squash merge this, using the above summary of changes as the commit message.