Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integration as described in #116
With this commit, a new district is no longer linked to a new aragon-id, but it is now a 2-step process where firstly the district is created, and then it is linked to Snapshot.
Thus, when creating a district, both the UI and District smart-contract has been modified to check the current user is the owner of the ens-name to be associated to the district. Once created, a new button appears to create the Snapshot, which will perform all the process required to create the snapshot (create and upload snapshot description to ipfs, update ens record, etc.).
Note: even though not explicitly said in the requirements, I added a check both in the UI and in the smart-contract side to avoid creating a district if the ens name is already linked to a snapshot (we can easily remove this checks if not actually needed).
Unit tests have been also adjusted.
Review notes
Testing notes