Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot integration #118

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Snapshot integration #118

merged 1 commit into from
Jul 16, 2021

Conversation

ginesdt
Copy link
Contributor

@ginesdt ginesdt commented Jul 6, 2021

Summary

Integration as described in #116
With this commit, a new district is no longer linked to a new aragon-id, but it is now a 2-step process where firstly the district is created, and then it is linked to Snapshot.
Thus, when creating a district, both the UI and District smart-contract has been modified to check the current user is the owner of the ens-name to be associated to the district. Once created, a new button appears to create the Snapshot, which will perform all the process required to create the snapshot (create and upload snapshot description to ipfs, update ens record, etc.).
Note: even though not explicitly said in the requirements, I added a check both in the UI and in the smart-contract side to avoid creating a district if the ens name is already linked to a snapshot (we can easily remove this checks if not actually needed).
Unit tests have been also adjusted.

Review notes

Testing notes

registry_01
registry_02
registry_03
registry_04

@madvas
Copy link
Contributor

madvas commented Jul 7, 2021

Hi, thanks for well made PRs. We might be interested in further collaboration with you, if you are as well, please drop us an email at [email protected]

@madvas madvas merged commit d3a4b6f into district0x:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants