Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autostop apps #144

Merged
merged 2 commits into from
Oct 24, 2024
Merged

autostop apps #144

merged 2 commits into from
Oct 24, 2024

Conversation

raphaellaude
Copy link
Collaborator

@raphaellaude raphaellaude commented Oct 23, 2024 •
edited
Loading

Description

  • Fly is so fast at spinning up machines again that we should autostop all apps except dbs, esp. for PR apps. We can always set min machines running to 1 for prod down the line, having different configs, but for now I think this is appropriate.

Reviewers

Checklist

  • Added/Updated related documentation (if applicable).
  • Added/Updated related unit tests (if applicable).

Screenshots (if applicable):

@raphaellaude raphaellaude changed the title autosleep pr apps autostop apps Oct 23, 2024
@raphaellaude raphaellaude self-assigned this Oct 23, 2024
mariogiampieri
mariogiampieri approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@mariogiampieri mariogiampieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@raphaellaude raphaellaude merged commit 7a0b4aa into main Oct 24, 2024
2 checks passed
@raphaellaude raphaellaude deleted the pr-apps-should-sleep-machines branch October 24, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariogiampieri mariogiampieri mariogiampieri approved these changes

Assignees

@raphaellaude raphaellaude

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphaellaude @mariogiampieri