Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider descendents of closed details unfocusable #6

Merged
merged 3 commits into from
Mar 17, 2024

Conversation

knuton
Copy link
Member

@knuton knuton commented Mar 16, 2024

Somewhat counterintuitively, descendents of closed details elements are seemingly not inert, invisible, dimensionless, etc. Therefore we have to detect them explicitly to exclude them from focusable elements.

@knuton knuton force-pushed the dimensionless-not-focusable branch 2 times, most recently from f8ca609 to 2502f8a Compare March 16, 2024 18:47
knuton added 3 commits March 16, 2024 20:27
cypress refuses to apply focus to some elements it does not consider focusable, even though all browsers apply focus just fine.
Somewhat counterintuitively, descendents of closed details elements are
seemingly not inert, invisible, dimensionless, etc. Therefore we detect
them explicitly to exclude them from focusable elements.
@knuton knuton force-pushed the dimensionless-not-focusable branch from 5060c4a to 5342be1 Compare March 16, 2024 19:27
@knuton knuton marked this pull request as ready for review March 16, 2024 19:30
@knuton knuton requested a review from krksgbr March 16, 2024 19:30
Copy link
Contributor

@krksgbr krksgbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@krksgbr krksgbr merged commit f7bca50 into dividat:main Mar 17, 2024
6 checks passed
@knuton knuton deleted the dimensionless-not-focusable branch March 17, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants