Use the mime crate to parse 'content-type' header into Media Types #3649

jcjones · 2025-02-07T01:08:42Z

Future work:

Change the validate_content_type signature to include version constraints, and apply them using the values now parsed out and available by the mime crate. (Support constraining methods to particular DAP versions #3650)

Closes #3609.

Modify validate_content_type First pass of collector's poll_once Match on the "essence" strings

core/src/retries.rs

aggregator/src/aggregator/http_handlers.rs

collector/src/lib.rs

core/src/retries.rs

core/src/http.rs

Co-authored-by: David Cook <[email protected]>

jcjones added 3 commits February 6, 2025 18:05

Begin using the mime crate for content-type headers

49366bd

Modify validate_content_type First pass of collector's poll_once Match on the "essence" strings

Test for updates to HttpErrorResponse

2f1c678

appease clippy

1f794bc

jcjones mentioned this pull request Feb 7, 2025

Support constraining methods to particular DAP versions #3650

Open

jcjones marked this pull request as ready for review February 7, 2025 02:07

jcjones requested a review from a team as a code owner February 7, 2025 02:07

divergentdave approved these changes Feb 7, 2025

View reviewed changes

core/src/retries.rs Outdated Show resolved Hide resolved

tgeoghegan reviewed Feb 7, 2025

View reviewed changes

aggregator/src/aggregator/http_handlers.rs Outdated Show resolved Hide resolved

collector/src/lib.rs Outdated Show resolved Hide resolved

core/src/retries.rs Outdated Show resolved Hide resolved

core/src/http.rs Show resolved Hide resolved

jcjones and others added 5 commits February 7, 2025 11:50

Update core/src/retries.rs

326436b

Co-authored-by: David Cook <[email protected]>

Restructure error handling for validate_content_type

842e0cd

Restructure mime error handling for poll_once

2ad6be8

Replace an extra static string with a use string

78ecd3b

Review updates

2af7c09

tgeoghegan approved these changes Feb 7, 2025

View reviewed changes

jcjones merged commit 5a39af1 into main Feb 10, 2025
8 checks passed

jcjones deleted the 3609-media-types-parameter branch February 10, 2025 16:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use the mime crate to parse 'content-type' header into Media Types #3649

Use the mime crate to parse 'content-type' header into Media Types #3649

jcjones commented Feb 7, 2025 •

edited

Loading

Use the mime crate to parse 'content-type' header into Media Types #3649

Use the mime crate to parse 'content-type' header into Media Types #3649

Conversation

jcjones commented Feb 7, 2025 • edited Loading

jcjones commented Feb 7, 2025 •

edited

Loading