Rename FFT to NTT #1202
Merged
Rename FFT to NTT #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
force-pushed
the
cjppatton/632
branch
from
3797e57 to
27240e8
Compare
divergentdave
approved these changes
Jan 18, 2025
src/benchmarked.rs
Outdated
| /// Sets `outp` to the Discrete Fourier Transform (DFT) using an iterative FFT algorithm. | ||
| pub fn benchmarked_iterative_fft<F: FftFriendlyFieldElement>(outp: &mut [F], inp: &[F]) { | ||
| discrete_fourier_transform(outp, inp, inp.len()).unwrap(); | ||
| /// Sets `outp` to the Discrete Fourier Transform (DFT) using an iterative NTT algorithm. |
There was a problem hiding this comment.
nit: We could also remove mention of the DFT from these two methods
There was a problem hiding this comment.
Done. FWIW, the recursive versus iterative NTT benchmark may not have a lot of value anymore.
cjpatton
force-pushed
the
cjppatton/632
branch
from
27240e8 to
d7d181a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #632.