Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make clean_error_msg public for protocol class users #371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Coservit
Copy link

Hello,
first, thanks for this library, really useful when managing windows host.
It seem the winrm.session class does not handle other code page except ascii, and the recommended way to go is using the protocol object if we need other codepage (see issue 258, 357, 333)
I use the protocol object successfully, but need to decode the clixml message if there is an error.
for that _clean_error_message is a useful method, but it's not accessible from the protocol object, and it's not public.
could you make this function public for everyone to use, without having to create a session object ?
tested on python3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant