Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions versions #2

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Update github actions versions #2

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74bed41
Update github actions versions
tim-schilling Sep 2, 2024
1893bd4
following the documentation they have
cunla Sep 2, 2024
0daebde
update to v1.10
cunla Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
name: python-package-distributions
path: dist/
- name: Publish distribution 📦 to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
uses: pypa/gh-action-pypi-publish@release/v1.10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why that one CI step is failing but this is the line it's failing on. I double checked and that branch definitely exists. I wondered if we didn't need the @release part, since the tag is available at v1.10.0, but I don't know why it would work in the other steps? TL;DR: I looked into why that one CI step failed and whether that mattered or was a red flag, and I'm not sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the documentation they have - it should be release/v1, however, considering release/v* are branch names, it should be release/v1.10


github-release:
name: >-
Expand All @@ -70,7 +70,7 @@ jobs:
name: python-package-distributions
path: dist/
- name: Sign the dists with Sigstore
uses: sigstore/gh-action-sigstore-python@v1.2.3
uses: sigstore/gh-action-sigstore-python@v3
with:
inputs: >-
./dist/*.tar.gz
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:
name: python-package-distributions
path: dist/
- name: Publish distribution 📦 to TestPyPI
uses: pypa/gh-action-pypi-publish@release/v1
uses: pypa/gh-action-pypi-publish@release/v1.10.0
with:
repository-url: https://test.pypi.org/legacy/
skip-existing: true
Loading