Improve category upsert and add test #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specialunderwear
requested changes
Sep 17, 2024
oscarapi/utils/categories.py
Outdated
| @@ -79,12 +80,16 @@ def upsert_categories(data): | |||
| if categories_to_update and fields_to_update: | |||
| Category.objects.bulk_update(categories_to_update, fields_to_update) | |||
|
|
|||
| Category.fix_tree() | |||
|
|
|||
|
|
|||
| def _upsert_categories(data, parent_category=None): | |||
| if parent_category is None: | |||
| # Starting from root, we want the first category in the root | |||
There was a problem hiding this comment.
Deze comment klopt nu niet meer of wel?
oscarapi/utils/categories.py
Outdated
| category.move(parent_category, pos="first-child") | ||
|
|
||
| # The category is now the sibling, new categories will be moved to the right of this category | ||
| sibling = category | ||
| sibling = Category.objects.get(pk=category.pk) |
There was a problem hiding this comment.
Waarom doe je hier een nieuwe query? Misschien dat move het geupdated object retourneerd?
samar-hassan
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Optimize attribute values (#321) * Implemented faster attributes save * renamed for clarity * Renamed warning * Enable shortcut when saving child products. (#322) * Make sure to only return attributevalues that are on the actual product to avoid transferring (#331) attributesvalues from parent to child. * Improve multi db support (#335) Use the same database as the passed-in manager * The image and file fields where nolonger working. (#337) * The image and file fields where nolonger working. This PR restores that functionality. * nergens voor * fixes tests * black * Fixes cyclic import error * Fixes handling of null product image attributes When an image product attribute is `null`, the product API would throw the following exception: ``` ValueError: The 'value_image' attribute has no file associated with it. […] File "rest_framework/serializers.py", line 522, in to_representation ret[field.field_name] = field.to_representation(attribute) File "rest_framework/serializers.py", line 686, in to_representation return [ File "rest_framework/serializers.py", line 687, in <listcomp> self.child.to_representation(item) for item in iterable File "rest_framework/serializers.py", line 522, in to_representation ret[field.field_name] = field.to_representation(attribute) File "oscarapi/serializers/fields.py", line 227, in to_representation return value.value.url File "django/db/models/fields/files.py", line 66, in url self._require_file() File "django/db/models/fields/files.py", line 41, in _require_file raise ValueError( ``` This patch fixes this by checking if the image field has a value before trying to generate a URL. * Add category bulk admin api * Add tests to prove how it works * wops * Added Jenkinsfile * hehe * set to next release version * Setup local CI (#348) * Improve category upsert and add test (#352) * Doe some updating and add test * refrhes_from_db only path * Add transaction that rollsback on error * update versions --------- Co-authored-by: Craig Weber <[email protected]> Co-authored-by: Viggo de Vries <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.