Add create_user endpoint #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Oluwatos94 fix pylint issue |
djeck1432
requested changes
Feb 25, 2025
margin_app/app/api/user.py
Outdated
|
|
||
| router = APIRouter() | ||
|
|
||
| class UserCreate(BaseModel): |
There was a problem hiding this comment.
this should be in another file, schemas/user.py
margin_app/app/api/user.py
Outdated
| class UserCreate(BaseModel): | ||
| wallet_id: str | ||
|
|
||
| class UserResponse(BaseModel): |
There was a problem hiding this comment.
this should be in another file, schemas/user.py
margin_app/app/api/user.py
Outdated
| created_at: datetime | ||
|
|
||
| @router.post("/users/", response_model=UserResponse) | ||
| async def create_user(user: UserCreate, db: AsyncSession = Depends(get_db)): |
There was a problem hiding this comment.
use user_crud https://github.com/djeck1432/spotnet/blob/main/margin_app/app/crud/user.py#L115 as it was in task description
|
@Oluwatos94 Please finalize your PR as soon as possible, You ran out of time |
|
@djeck1432 Could you check if it's all good now? Thank you! |
|
@Oluwatos94 sync with main branch please |
|
@Oluwatos94 any updates so far? |
|
Please, I will fix it when I get home. Not close to my laptop at the moment
🙏
…On Thu, Feb 27, 2025, 6:42 PM djeck1432 ***@***.***> wrote:
@Oluwatos94 <https://github.com/Oluwatos94> any updates so far?
—
Reply to this email directly, view it on GitHub
<#658 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2O4NL5NKS2ZULMP5SKEJTT2R5E6RAVCNFSM6AAAAABX24Z546VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBYGY3DMMZUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: djeck1432]*djeck1432* left a comment (djeck1432/spotnet#658)
<#658 (comment)>
@Oluwatos94 <https://github.com/Oluwatos94> any updates so far?
—
Reply to this email directly, view it on GitHub
<#658 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2O4NL5NKS2ZULMP5SKEJTT2R5E6RAVCNFSM6AAAAABX24Z546VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBYGY3DMMZUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft: [Margin App] Create endpoint for creating user
Description
This PR adds a new endpoint for creating a user. The endpoint accepts a
wallet_idand returns the created user object.Changes
create_userendpoint inuser.pycrud/user.pyNotes
This is a draft PR. Further implementation and testing will be done in subsequent commits.