feat/fixed and improved pool page #698
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and currently making use of the tab component. created a use-mobile hook for breakpoint. matched page with figma design.
|
close-[#698] and on mobile |
Prosper1218
changed the title
whateverfw
requested changes
Mar 5, 2025
Comment on lines
21
to
23
| // ////// | ||
|
|
||
|
|
margin_frontend/package-lock.json
Outdated
| @@ -36,19 +36,19 @@ export default function PoolCard({ pool }: PoolCardProps) { | |||
| </div> | |||
| </div> | |||
|
|
|||
| {pool.isDegen && <div className="bg-[#333] px-2 py-1 rounded text-xs text-gray-300">Degen</div>} | |||
| {pool.isDegen && <div className="bg-[#333] px-2 py-1 rounded text-xs text-gray-300 flex flex-row items-center gap-1"> <div className="h-[8px] w-[8px] bg-[#898989] rounded-[2px]"></div>Degen</div>} | |||
There was a problem hiding this comment.
sizes can be set with size-2, instead of arbitrary values, also colros should be put into theme inside index.css
There was a problem hiding this comment.
check font sizes, do not match figma
margin_frontend/src/ui/core/tab.tsx
Outdated
| ? " rounded-t-lg text-baseWhite bg-navbg border-b border-activeTab " | ||
| : "text-tabText hover:text-baseWhite " | ||
| }`} | ||
| className={`p-4 text-[16px] font-[400] focus:outline-none transition-colors w-full max-w-[142px] ${activeIndex === index |
There was a problem hiding this comment.
font-[400] can be replaced with tailwind utility, as well as text-[16px]
|
on it. |
|
whateverfw
approved these changes
Mar 6, 2025
|
hello @whateverfw, Any pending stuff ? |
|
no, I've approved it @Prosper1218 |
alright.. Although i can still see the issue under open issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr is a work in progress, but will make the pool page responsive.