Skip to content

Commit

Permalink
move Fortran library dependencies from cpgplot.pc to pgplot.pc
Browse files Browse the repository at this point in the history
The Fortran library dependencies were erroneously put in the Libs
entry in cpgplot.pc rather than pgplot.pc.  This didn't affect
the internal tests.

However, the result was that -lgfortran was placed before -lpgplot
(for example), and on systems which perform single pass symbol lookup
during linking (e.g. most recent Linux boxes), the symbols in gfortran
which were required by pgplot were never resolved.
  • Loading branch information
djerius committed Jun 15, 2022
1 parent ae84274 commit 5d43207
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
8 changes: 8 additions & 0 deletions NEWS
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
5.2.2-8

[BUG FIX]

* pkg-config files specified out-of-order Fortran libraries which
cause links to fail on systems which perform single pass symbol
resolution.

5.2.2-7

[BUILD FIXES]
Expand Down
2 changes: 1 addition & 1 deletion cpgplot.pc.in
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ Name: PGplot
Description: C 2D Graphics library
Version: ${version}
Requires: pgplot @PKG_CONFIG_REQUIRES@
Libs: -L${libdir} -lcpgplot @FLIBS@
Libs: -L${libdir} -lcpgplot
Cflags: -I${includedir}
2 changes: 1 addition & 1 deletion pgplot.pc.in
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ Name: PGplot
Description: Fortran 2D Graphics library
Version: ${version}
Requires: @PKG_CONFIG_REQUIRES@
Libs: -L${libdir} -lpgplot @PKG_CONFIG_LIBS@
Libs: -L${libdir} -lpgplot @FLIBS@ @PKG_CONFIG_LIBS@
Cflags: -I${includedir}

0 comments on commit 5d43207

Please sign in to comment.