Use pkg-config to get x11 and xt flags #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2021
Merged
djerius
reviewed
Oct 29, 2021
Because these are listed in `$X_PRE_LIBS`.
zmughal
force-pushed
the
pkg-config-x11-xt
branch
from
0067775 to
f2929d2
Compare
|
I have rebased on top of the main branch. I also added a commit to test using the |
oodler577
reviewed
Nov 12, 2021
|
@djerius, have a moment to look over this? |
djerius
requested changes
Jan 2, 2022
zmughal
force-pushed
the
pkg-config-x11-xt
branch
2 times, most recently
from
7b858e2 to
c78c98c
Compare
|
@djerius, now that change should work. More details in the commit:
|
Co-authored-by: djerius <[email protected]>
Per the macOS ld(1) man page <https://www.unix.com/man-page/OSX/1/ld/>, > The default library search path is /usr/lib then /usr/local/lib. When `HOMEBREW_PREFIX=/usr/local`, this is where the `.dylib` files for X11 are symlinked by Homebrew. When `AC_PATH_XTRA` is called, it uses `/usr/bin/gcc` (Apple clang) and since the libraries are found in `/usr/local/lib`, it does not need to specify any `-L` paths. However when `libtool` is used to call Homebrew `gfortran`, it sets the flag `-syslibroot` which per the man page for ld(1): > The -syslibroot option will prepend a prefix to all search paths. and this means that it no longer looks under `/usr/local/lib` by default. To fix this, add the default path back by setting the `LIBRARY_PATH` environment variable.
zmughal
force-pushed
the
pkg-config-x11-xt
branch
2 times, most recently
from
98f1723 to
bb4bc01
Compare
zmughal
force-pushed
the
pkg-config-x11-xt
branch
4 times, most recently
from
3cbd03b to
7515756
Compare
This is to test that if libraries are not symlinked into the Homebrew prefix (here by using `brew unlink`), then `autotool` will use `pkg-config` to find the libraries.
zmughal
force-pushed
the
pkg-config-x11-xt
branch
from
7515756 to
e8a55e2
Compare
|
@djerius, the latest commits should now test the case where |
|
Sorry about the delay! |
|
Not a problem! I was wondering if the next thing to tackle is getting #1 incorporated (hopefully it can be done and the license can be worked out). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on top of the commits of #2.
As discussed in #2, some
package managers (e.g., Homebrew) do not place x11 and xt files in the standard
locations. This uses
pkg-configto get that information first.