remove temp object in GetOffers

dkackman · Mar 25, 2022 · a2e0e43 · a2e0e43
1 parent d24fb46
commit a2e0e43
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/src/chia-dotnet/TradeManager.cs b/src/chia-dotnet/TradeManager.cs
@@ -79,17 +79,11 @@ public async Task<IEnumerable<OfferRecord>> GetOffers(int start, int end, bool e
 
             var response = await WalletProxy.SendMessage("get_all_offers", data, cancellationToken).ConfigureAwait(false);
 
-            var rTemp = new
-            {
-                response.offers,
-                response.success,
-                response.trade_records
-            };
-
-            var tradeRecords = Converters.ToObject<TradeRecord[]>((rTemp.trade_records as object).ToJson());
-            var offers = Converters.ToObject<string[]>((rTemp.offers as object).ToJson());
+            // need to explicitly decalre these two types to cast away any dynamicness
+            TradeRecord[] tradeRecords = Converters.ToObject<TradeRecord[]>(response.trade_records);
+            string[] offers = Converters.ToObject<string[]>(response.offers);
 
-            var zipped = offers!.Zip(tradeRecords!);
+            var zipped = offers.Zip(tradeRecords);
 
             return from zip in zipped
                    select new OfferRecord()