No effect hit types, shots do damage #3310
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is about removing HitType to effects.toml? |
That would be done with this too yes. The big picture is that having hittype at many places is weird especially because they usually do not work. So doing a lot more through shots seems best to me. Notice too that this way gas damage and range becomes configurable from the shot, and we also get rid of the weird hardcoding to the WoP shots for the traps and creature abilities. (making it possible to have more different WoP type attacks). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion to rework hittypes on effects, specifically how Gas and Word of Power do damage.
Related PR: #2538 Making farts configurable
PR to partially revert: #3051
PR in the current state is design idea, to be discussed on discord. Walters welcome.