Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holes in magic.cfg and extended to 2000 #3311

Merged
merged 14 commits into from
Sep 15, 2024

Conversation

rainlizard
Copy link
Contributor

No description provided.

@rainlizard rainlizard marked this pull request as draft June 16, 2024 01:45
@rainlizard rainlizard marked this pull request as ready for review June 22, 2024 16:55
@Loobinex Loobinex requested a review from benlp91 June 23, 2024 20:10
@PieterVdc PieterVdc mentioned this pull request Jul 4, 2024
9 tasks
@Loobinex Loobinex requested a review from walt253 July 4, 2024 22:45
@Loobinex
Copy link
Member

Loobinex commented Jul 4, 2024

@walt253 ben offered to test but says he is quite busy now. Would you be so inclined?

@walt253
Copy link
Contributor

walt253 commented Jul 5, 2024

Ok

@Loobinex
Copy link
Member

Loobinex commented Jul 8, 2024

Ok

so, does it all work?

@Loobinex
Copy link
Member

It has been left to simmer, because it does not work. To not forget it, this is what is wrong:
image

Causes this bug:

  1. Start campaign level 15
  2. Claim portal, reveal map
  3. Frameskip
    -> Notice Green and Blue do not assign any units to their libraries

@benlp91 benlp91 marked this pull request as draft September 15, 2024 07:00
@benlp91 benlp91 marked this pull request as ready for review September 15, 2024 07:00
@Loobinex Loobinex marked this pull request as draft September 15, 2024 13:49
@Loobinex Loobinex marked this pull request as ready for review September 15, 2024 13:49
@Loobinex Loobinex marked this pull request as draft September 15, 2024 13:55
@Loobinex Loobinex marked this pull request as ready for review September 15, 2024 13:56
@Loobinex Loobinex merged commit f3a4a39 into dkfans:master Sep 15, 2024
1 check passed
Linvail added a commit to Linvail/keeperfx that referenced this pull request Sep 15, 2024
Holes in magic.cfg and maximums extended to 2000 (dkfans#3311)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants