-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increased creature limit #3362
Merged
Merged
Increased creature limit #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a better description to the rules.cfg
the code changes in [src/console_cmd.c] are to be able to show the amount of creatures in the pool with a console command. i don't know if that would need a seperate alpha. |
and the show pool is minor enough that doing it in this one is fine |
changed the name to MapCreaturesLimit and made the rules that old maps and campaigns have the old 256 creature count
Loobinex
reviewed
Aug 10, 2024
Loobinex
reviewed
Aug 10, 2024
Loobinex
reviewed
Aug 10, 2024
Loobinex
reviewed
Aug 10, 2024
Loobinex
reviewed
Aug 10, 2024
Loobinex
force-pushed
the
increased-creature-limit
branch
from
September 8, 2024 22:27
d021103
to
97d430f
Compare
Loobinex
force-pushed
the
increased-creature-limit
branch
from
September 8, 2024 22:59
df8a694
to
7b0eee0
Compare
PieterVdc
reviewed
Sep 9, 2024
It's 1024, but creature 0 is there too and 1 creature as a buffer to grow up and transfer without problems.
Loobinex
force-pushed
the
increased-creature-limit
branch
from
September 10, 2024 15:46
ee1ee66
to
fb6364e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: TOP POST BELONGS TO LOOBINEX NOW
Changes:
!map.pool [creaturetype]
to get how many of a type are in the portal.back to you ben:
Prepared for evaluation. This is the code for a rule in the rules.cfg named 'Creatures_Count = 1028'.
You have the option to reduce the number of creatures below this value in the rule.cfg. This rule applies to all players, including Imps, with 1028 being the maximum allowed.
I have conducted tests with multiply creatures and creature transfers without encountering any issues. The Scavenger does not exceed the limit from the pool. However, the graveyard functionality has not been tested."
Side note: While there don't appear to be any pathfinding issues, teleporting a thousand creatures simultaneously may lead to performance issues. It is important for every mapmaker to ensure that their configurations are optimized for high performance, even on less powerful PCs. that will change with the per Player rule in the future.