Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy ruleset matches original game better #3472

Merged
merged 17 commits into from
Oct 9, 2024
Merged

Legacy ruleset matches original game better #3472

merged 17 commits into from
Oct 9, 2024

Conversation

Loobinex
Copy link
Member

@Loobinex Loobinex commented Sep 18, 2024

Fixes #3466

Changes:

  • Lvl10 keeper powers, set to bugged values for legacy
  • Strength caps instead of overflows with the bug mode
  • Sight uses the correct power value
  • Defense value not in fact capped to 255
  • Firebomb/meteor emulates the 'no explode on creature impact' bug
  • Arrow not strength based
  • luck stats divided by 2.55 to compensate for difference in luck calculation between dk1 and fx (/100 instead of /255).
  • stats that were previously altered compared to original game to compensate from the lack of the above changes reverted to original values.

@Loobinex Loobinex marked this pull request as ready for review September 19, 2024 23:35
@Loobinex Loobinex marked this pull request as draft September 20, 2024 23:57
@Loobinex Loobinex marked this pull request as ready for review September 20, 2024 23:57
@Loobinex Loobinex marked this pull request as draft October 4, 2024 19:11
@Loobinex Loobinex marked this pull request as ready for review October 4, 2024 19:11
@Loobinex Loobinex marked this pull request as draft October 5, 2024 13:37
@Loobinex Loobinex marked this pull request as ready for review October 5, 2024 13:41
@Loobinex Loobinex changed the title Added the 10th creature spell level on powers Legacy ruleset matches original game better Oct 7, 2024
@Loobinex Loobinex marked this pull request as draft October 7, 2024 10:45
@Loobinex Loobinex marked this pull request as ready for review October 7, 2024 10:47
@Loobinex Loobinex requested a review from walt253 October 7, 2024 10:48
src/config_magic.c Outdated Show resolved Hide resolved
Copy link
Contributor

@walt253 walt253 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really tell for the creatures change on the legacy part, rest of code seems ok to me.

@Loobinex Loobinex marked this pull request as draft October 8, 2024 13:50
@Loobinex Loobinex marked this pull request as ready for review October 8, 2024 13:50
@Loobinex Loobinex merged commit 123e68d into master Oct 9, 2024
1 check passed
@Loobinex Loobinex deleted the power10 branch October 9, 2024 09:02
Loobinex added a commit that referenced this pull request Oct 9, 2024
Fixes #3466

Changes:

- Lvl10 keeper powers, set to bugged values for legacy
- Strength caps instead of overflows with the bug mode
- Sight uses the correct power value
- Defense value not in fact capped to 255
- Firebomb/meteor emulates the 'no explode on creature impact' bug
- Arrow not strength based
- Luck stats divided by 2.55 to compensate for difference in luck calculation between dk1 and fx (/100 instead of /255).
- Reverted stat changes from legacy that were to compensate for above issues
- Added some extra (original) stats to legacy that are different in FX

---------

Co-authored-by: elemanzer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AK Lvl 13 Sloth - Orcs are too weak to progress the level.
2 participants