Small Refactor for thing_stats.c #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: |
prevent log errors when trying to get player 9 dungeon
This comment was marked as outdated.
This comment was marked as outdated.
so it doesn't try to get dungeon from ALL_PLAYERS (player 9)
This comment was marked as spam.
This comment was marked as spam.
also cause I ran into a build warning
Loobinex
reviewed
Nov 7, 2024
Unable to reproduce the previous errors, it seems the check is useless - better to fix the underlying issue if it happens again
Make the file a bit clearer...
|
I merged in the cosmetic stuff from #3653 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reordered stuff in thing_stats.c.
Removed boolean argument on
compute_creature_max_armourthe buff is now checked oncalculate_correct_creature_armour.Added
calculate_correct_creature_defenseandcalculate_correct_creature_dexterityand change few functions accordingly (see creature_states_combt.c - thing_creature.c - thing_shots.c).Removed dungeon modifier on
project_creature_attack_melee_damageandcompute_creature_attack_melee_damageas it's no longer required since calculate_correct_creature_strength is now used where it should be (see thing_creature.c).