Fixed Teleport #3531
Merged
Fixed Teleport #3531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dkfans#3530
walt253
reviewed
Oct 7, 2024
| @@ -1803,7 +1803,7 @@ void creature_cast_spell(struct Thing *castng, SpellKind spl_idx, long shot_lvl, | |||
| cctrl->teleport_y = trg_y; | |||
| } | |||
|
|
|||
| if (spconf->caster_affected && castng->index == cctrl->targtng_idx) | |||
| if (spconf->caster_affected) | |||
There was a problem hiding this comment.
Maybe Teleport should have its special case/check to not mess with others stuff?
There was a problem hiding this comment.
It is a design choice we have to make. We need to set rules for setting the target parameter of the instance, i.e. the 3rd parameter of set_creature_instance().
I suggest that for teleport we set caster itself as the target parameter. It can imply that the spell teleport "caster itself" to somewhere. In the future, we could extend its function to allow it to teleport "another creature" to somewhere.
walt253
approved these changes
Oct 7, 2024
Linvail
reviewed
Oct 7, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Loobinex
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3530