Play FMVs using ffmpeg instead of smackw32.dll #3573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is some build warnings related to that PR: build: src/bflib_fmvids.cpp#L514 build: deps/ffmpeg/libavutil/frame.h#L582 |
|
Yes, we know but there is no proper fix for this at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will play videos using ffmpeg instead of relying on smackw32.dll. This a required change for cross-platform support.
Because there's no OpenAL yet, I've added (temporary) audio playback through SDL. There's some occasional glitching, likely due to buffer underruns. This can be solved by buffering a few frames in advance.
The size of ffmpeg can be reduced by playing with configure options, it currently includes a lot of codecs and other formats which are not used.