Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Roar & Piss from Dig animation and fill fields for all creatures #3607

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

walt253
Copy link
Contributor

@walt253 walt253 commented Oct 30, 2024

Both Roar and Piss were previously tied to the Dig animation, causing issues when creating a digger capable of going into a mad psycho state or urinating on corpses. This PR changes that.

I’ve filled out all the fields for the creatures based on the following logic:

  • Dig for all creatures set to use their Attack animation.
  • PrettyDance for all creatures set to use their Celebrate animation.
  • Roar for all creatures set to use their Celebrate animation (following the Reaper's example).
  • Piss for all creatures set to use their Scream animation, except for the Hound, which has its own animation.
  • Smoke & Relax for all Good creatures set to use their Sleep animation, as they don’t have a lair in it.
  • Smoke & Relax for all Evil creatures set to use their Scream animation.

Exceptions:

  • Hell Hound uses its Piss animation for both Smoke and Relax.
  • Imp uses its Smoke animation for Roar and Relax animation for Piss.

Note: I changed Tunneller's PrettyDance to use its Celebrate animation instead of Attack. Let me know if you’d like this reverted.

@walt253 walt253 marked this pull request as ready for review October 30, 2024 08:03
@walt253 walt253 requested a review from Loobinex October 30, 2024 11:34
Copy link
Member

@Loobinex Loobinex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walt253 yes, please revert the tunneler change. I dislike celebrate there because this animation only has a single rotation. Beyond that, I would merge.

@Loobinex Loobinex merged commit c97846e into dkfans:master Nov 1, 2024
@walt253 walt253 deleted the SplitRoarPissFromDig branch November 1, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants