Traps: InstantPlacement & RemoveOnceDepleted

[walt253]

Two new properties for traps: InstantPlacement & RemoveOnceDepleted.

; Place the trap immediately without needing imps to drag the crate to arm it.
InstantPlacement = 0
; Destroy the trap once it runs out of Shots.
RemoveOnceDepleted = 0

Good for tower defense map.

[PieterVdc]

I suppose TrapStats should still get merged into TrapConfigStats, any reason why 1 of the properties is in 1 and the other in the other?

[walt253]

I suppose TrapStats should still get merged into TrapConfigStats, any reason why 1 of the properties is in 1 and the other in the other?

Yes, merging those two in a future PR would be a good idea.

The reason for this PR is simply that it was more practical:

struct TrapConfigStats* trap_cfg = get_trap_model_stats(tngmodel); is already being used in player_place_trap_at.
struct TrapStats* trapstat = &game.conf.trap_stats[traptng->model]; is already being used in process_trap_charge.

[walt253]

I suppose TrapStats should still get merged into TrapConfigStats, any reason why 1 of the properties is in 1 and the other in the other?

Yes, merging those two in a future PR would be a good idea.

The reason for this PR is simply that it was more practical:

struct TrapConfigStats* trap_cfg = get_trap_model_stats(tngmodel); is already being used in player_place_trap_at. struct TrapStats* trapstat = &game.conf.trap_stats[traptng->model]; is already being used in process_trap_charge.

I'm working on merging it now but this will be for a separate PR. I started yesterday and got tons of builds errors I fixed, still a few remaining but so far so good. I would like to get this PR merged first however.

[PieterVdc]

to me code looks fine, and yeah merging should be seperate PR so fine by me

[walt253]

I fixed the conflicts.

[Spatulade]

👍 looks good, and will come in handy for eventually being able to place and remove traps via script.

(I assume you can't do the opposite and force doors to be placed with crates because doors are slabs and transparency wouldn't work for slabs and it'd probably involve making some sort of "door blueprint" slab that only you can see etc etc and that would be awful to code)