round shot logic #3795
Draft
round shot logic #3795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loobinex
reviewed
Jan 2, 2025
src/config_magic.c
Outdated
| @@ -126,6 +126,7 @@ const struct NamedCommand magic_shot_commands[] = { | |||
| {"SPEEDDEVIATION", 58}, | |||
| {"SPREAD_XY", 59}, | |||
| {"SPREAD_Z", 60}, | |||
| {"SPREAD_CIRCULAR", 60}, | |||
There was a problem hiding this comment.
This needs to be a unique number
Loobinex
reviewed
Jan 2, 2025
src/config_magic.c
Outdated
| n++; | ||
|
|
||
| // Generate random position within a circle for XY | ||
| float angle = ((float)rand() / RAND_MAX) * 2 * M_PI; // Random angle between 0 and 2π |
There was a problem hiding this comment.
We do not use floats in any code that should remain in sync, and projectiles are certainly among that. No rand() either, use our synced random functions. This will break packetsave and multiplayer.
There was a problem hiding this comment.
Also don't do this on the config :p
walt253
reviewed
Jan 2, 2025
| shotst->spread_circular = k; // Set the value for combined scattering | ||
| n++; | ||
|
|
||
| // Generate random position within a circle for XY |
There was a problem hiding this comment.
You are in the config function, you don't do any logic like this here. This function is only meant to assign a value to variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.