-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handgold and payday rules #3847
Open
Shinthoras0815
wants to merge
16
commits into
dkfans:master
Choose a base branch
from
Shinthoras0815:handgold-and-payday-rules
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
89745fb
max advanced & owed payday rules
Shinthoras0815 f1a8a6b
AcceptPartialPayday rule
Shinthoras0815 e640560
PocketGold Rule
Shinthoras0815 7b1f3a0
TakePayFromPocket Rule
Shinthoras0815 8165b06
waiting at door is a valid state
Shinthoras0815 4722fef
handle happiness reward
Shinthoras0815 884289c
correct anger calculation for picked up gold
Shinthoras0815 12abb0d
corrected custom salary & and comments
Shinthoras0815 9191c4c
payday_owed instead of creature_state
Shinthoras0815 88d3e58
Merge branch 'master' into handgold-and-payday-rules
Shinthoras0815 f06a92e
Update rules.cfg
Shinthoras0815 a179ad1
Merge branch 'master' into pr/3847
Loobinex 9348ee9
fixed build error processpayday_advances
Loobinex 76a8379
fixed rules.cfg comments
Loobinex 4abdd14
Update rules.cfg
Shinthoras0815 1809bac
creatures consum always all gold at AcceptPartialPayday
Shinthoras0815 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is 'not partial payday' here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If allowed with accept_partial_payday,
creatures would take the full salary even if they were already partially paid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but by accepting partial paydays, you would always take 0 payday next payday on any cash right? So would it not need to be fully excluded before this point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not about excluding accept_partial_payday, but rather about allowing !accept_partial_payday so that in this case the salary is calculated differently.