Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put all metadata calls into GC #20833

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Conversation

schveiguy
Copy link
Member

The GC is now fully responsible for storing and managing all metadata in GC blocks. The runtime will now just use GC calls to manage the metadata.

This allows GCs to innovate with how to store the metadata and not make any assumptions about the storage and retrieval of metadata.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @schveiguy!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20833"

@thewilsonator thewilsonator added the Druntime:GC Issues relating the Garbage Collector label Feb 7, 2025
@schveiguy schveiguy force-pushed the arraymetaingc branch 2 times, most recently from 30acbd4 to e119fdd Compare February 7, 2025 01:59
core/internal/array. All metadata management should be done by GC.
@schveiguy
Copy link
Member Author

Unsure what to do about the macos failure. I've rerun it, and it still fails "Error: The operation was canceled."

What does that mean?

@kinke
Copy link
Contributor

kinke commented Feb 9, 2025

Unsure what to do about the macos failure. I've rerun it, and it still fails "Error: The operation was canceled."

What does that mean?

It means the job was killed after hitting the 40 mins time-out - the Phobos tests shouldn't take more than a few minutes, but apparently hang from time to time on macOS. AFAICT, unrelated to your changes, as master is red too: https://github.com/dlang/dmd/actions/runs/13211623619/job/36885753688 (with latest DMD as host compiler, not bootstrap DMD as here).

@thewilsonator thewilsonator merged commit 0542419 into dlang:master Feb 9, 2025
41 of 42 checks passed
@schveiguy schveiguy deleted the arraymetaingc branch February 10, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Druntime:GC Issues relating the Garbage Collector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants