dv2: code comment (airbytehq#33328)

dlouseiro · Dec 12, 2023 · a2b160b · a2b160b
1 parent 19554f9
commit a2b160b
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/...n/java/io/airbyte/cdk/integrations/destination/jdbc/typing_deduping/JdbcSqlGenerator.java b/...n/java/io/airbyte/cdk/integrations/destination/jdbc/typing_deduping/JdbcSqlGenerator.java
@@ -62,9 +62,11 @@ protected DataType<?> toDialectType(final AirbyteType type) {
 
   protected DataType<?> toDialectType(final AirbyteProtocolType airbyteProtocolType) {
     return switch (airbyteProtocolType) {
-      // Many destinations default to a very short length (e.g. Redshift defaults to 256)
+      // Many destinations default to a very short length (e.g. Redshift defaults to 256).
+      // Explicitly set 64KiB here. Subclasses may want to override this value.
       case STRING -> SQLDataType.VARCHAR(65535);
-      // We default to precision=39, scale=9 across destinations
+      // We default to precision=38, scale=9 across destinations.
+      // This is the default numeric parameters for both redshift and bigquery.
       case NUMBER -> SQLDataType.DECIMAL(38, 9);
       case INTEGER -> SQLDataType.BIGINT;
       case BOOLEAN -> SQLDataType.BOOLEAN;