Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allows AnyUrl pydantic types #2286

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from
Open

fix: allows AnyUrl pydantic types #2286

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9be354f
fix: allows `AnyUrl` pydantic types
joscha Feb 11, 2025
b4acabf
Update __init__.py
joscha Feb 12, 2025
b4a0473
Update __init__.py
joscha Feb 12, 2025
fadd8e6
Update dlt/common/json/__init__.py
joscha Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dlt/common/json/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
except ImportError:
PydanticBaseModel = None # type: ignore[misc]

try:
from pydantic import AnyUrl as PydanticAnyUrl
except ImportError:
PydanticAnyUrl = None # type: ignore[misc]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cargo-culted this from above - I am assuming this is for the case when the Pydantic classes are not available and meant to gracefully degrade?


from dlt.common import known_env
from dlt.common.pendulum import pendulum
from dlt.common.arithmetics import Decimal
Expand Down Expand Up @@ -49,6 +54,8 @@ def custom_encode(obj: Any) -> str:
return dataclasses.asdict(obj) # type: ignore
elif isinstance(obj, Enum):
return obj.value # type: ignore[no-any-return]
elif isinstance(obj, PydanticAnyUrl):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to also test wether pydanticanyurl is defined, see above how it is done with the Basemodel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can, but going by @rudolfix' comment the implementation of this might become a fully custom hook anyway, no?

return obj.unicode_string() # will NOT punycode encode the host
raise TypeError(repr(obj) + " is not JSON serializable")


Expand Down
Loading