-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a "LIMIT 1" clause to the fetch state query in BigQuery client #2316
base: devel
Are you sure you want to change the base?
Conversation
…used later in the code.
✅ Deploy Preview for dlt-hub-docs canceled.
|
I don't think this will work with all destinations, mssql has a different syntax for example. |
@sh-rp ah, you are right, thank you! I have to think about different solution. |
I couldn't think anything better than moving "LIMIT 1" clause to specific BigQuery client. |
@xneg sorry for not responding in more detail earlier, it just occured to me that we already have a solution for this, albeit not a very elegant one. Check the _limit_clause_sql function that has a special implementation for mssql and how it is used in the datasets. You can just use that to achieve what you want with a 2 line code change. Let me know if you need help. |
Additional thought: you might also want to apply this to get_stored_schema, the same problem could arise. |
@sh-rp Thank you! It's good idea although a bit more than 2 lines of code. And thank you for hint with get_stored_schema, I applied changes there too. |
@sh-rp |
@rudolfix I added ci from fork to our workflows a year ago or so and it is still there, but it does not work for some reason... |
Description
Added a "LIMIT 1" clause to the fetch state query in BigQuery client since only the first record is used later in the code.
Related Issues