Skip to content

Commit

Permalink
AOF: run tests with preamble off when it makes sense.
Browse files Browse the repository at this point in the history
  • Loading branch information
antirez committed Mar 25, 2018
1 parent 28d28ef commit 2b2652d
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tests/integration/aof-race.tcl
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
set defaults { appendonly {yes} appendfilename {appendonly.aof} }
set defaults { appendonly {yes} appendfilename {appendonly.aof} aof-use-rdb-preamble {no} }
set server_path [tmpdir server.aof]
set aof_path "$server_path/appendonly.aof"

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/aofrw.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ start_server {tags {"aofrw"}} {
}
}

start_server {tags {"aofrw"}} {
start_server {tags {"aofrw"} overrides {aof-use-rdb-preamble no}} {
test {Turning off AOF kills the background writing child if any} {
r config set appendonly yes
waitForBgrewriteaof r
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/other.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ start_server {tags {"other"}} {
} {1}

test {Same dataset digest if saving/reloading as AOF?} {
r config set aof-use-rdb-preamble no
r bgrewriteaof
waitForBgrewriteaof r
r debug loadaof
Expand Down Expand Up @@ -126,6 +127,7 @@ start_server {tags {"other"}} {
test {EXPIRES after AOF reload (without rewrite)} {
r flushdb
r config set appendonly yes
r config set aof-use-rdb-preamble no
r set x somevalue
r expire x 1000
r setex y 2000 somevalue
Expand Down
3 changes: 2 additions & 1 deletion tests/unit/scripting.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,7 @@ start_server {tags {"scripting"}} {
test {EVAL processes writes from AOF in read-only slaves} {
r flushall
r config set appendonly yes
r config set aof-use-rdb-preamble no
r eval {redis.call("set",KEYS[1],"100")} 1 foo
r eval {redis.call("incr",KEYS[1])} 1 foo
r eval {redis.call("incr",KEYS[1])} 1 foo
Expand Down Expand Up @@ -629,7 +630,7 @@ foreach cmdrepl {0 1} {
}

start_server {tags {"scripting repl"}} {
start_server {overrides {appendonly yes}} {
start_server {overrides {appendonly yes aof-use-rdb-preamble no}} {
test "Connect a slave to the master instance" {
r -1 slaveof [srv 0 host] [srv 0 port]
wait_for_condition 50 100 {
Expand Down

0 comments on commit 2b2652d

Please sign in to comment.