#22 Add global play/pause #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Awesome work! Do you know if your fork still works with the current version of HA? |
|
Hi, thanks! Yes it does, I'm on the latest Home Assistant 2023.8.3 and LedFx v2.0.71 |
|
This feature - and only this feature - is now available as a new integration: https://github.com/guix77/homeassistant-ledfx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a PR implementing my feature request: #22
I went with the addition of a media_player entity. After all, LedFx is (kind of) a media player. Thought it would make more sense to put the play & pause feature into a media_player than in a switch. Also, we could add other new features like setting the global intensity (which could be the media_player "volume". Finally, the already existing feature of switching LedFx's audio source could be implemented in an async_select_source function of the media player.
For the coding style, I went straight to the point and didn't structure as well as the existing code. Let me know if you have suggestions to improve this.
Thanks :)