Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that addresses the underlying problem of aframevr/aframe#5311. Whenever the
update
method on theTextGeometry
is called, theboundingBox
andboundingSphere
will now be recomputed (if present). This is the same logic thatBufferGeometry
andLineSegmentsGeometry
use.Note: this PR can't be automatically merged as I rebased it onto the latest master of the original repository (https://github.com/Jam3/three-bmfont-text). This included a couple of nice clean-ups, like the removal of the dependency on https://github.com/Jam3/three-buffer-vertex-data and the
object-assign
ponyfill. For easier reviewing, please see: