Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare CRAN submission for 0.81 release #3994

Closed
wants to merge 1 commit into from

Conversation

hetong007
Copy link
Member

@hcho3 I'm bringing changes from #3988 into release_0.81 branch. Let me know if there's other ways to patch.

@codecov-io
Copy link

Codecov Report

Merging #3994 into release_0.81 will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             release_0.81    #3994     +/-   ##
=================================================
- Coverage           51.95%   51.76%   -0.2%     
  Complexity            203      203             
=================================================
  Files                 182      182             
  Lines               14500    14500             
  Branches              495      495             
=================================================
- Hits                 7534     7506     -28     
- Misses               6728     6756     +28     
  Partials              238      238
Impacted Files Coverage Δ Complexity Δ
src/common/transform.h 89.28% <ø> (ø) 0 <0> (ø) ⬇️
python-package/xgboost/core.py 77.79% <0%> (-4.45%) 0% <0%> (ø)
python-package/xgboost/compat.py 89.09% <0%> (-1.82%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b39590...c27fe8d. Read the comment docs.

@hcho3
Copy link
Collaborator

hcho3 commented Dec 14, 2018

Looks good to me

@hetong007
Copy link
Member Author

Our submission was blocked because it broke a reverse-dependent package.

I have informed the package author at: ymattu/MlBayesOpt#64

Still need to investigate which side is responsible for the fix. I suggest we hold this PR for potential future patches.

@trivialfis trivialfis closed this Dec 22, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Mar 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants