Merge pull request #30 from dmstr/feature/cmd-refactoring

improved command generation
dmstr · Dec 8, 2020 · d9223fa · d9223fa
2 parents 9591845 + 2058b3a
commit d9223fa
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/console/controllers/MysqlController.php b/console/controllers/MysqlController.php
@@ -347,10 +347,14 @@ public function actionDump()
         // dump tables with data
         $command = CliHelper::getMysqlCommand('mysqldump', $db);
         $command->addArg('--no-tablespaces');
+        $command->addArg('--opt');
 
-        $noDataTables = explode(',', $this->noDataTables);
-        foreach ($noDataTables as $table) {
-            $command->addArg('--ignore-table', $opts['db'] . '.' . $table);
+        if ($this->noDataTables) {
+            $noDataTables = explode(',', $this->noDataTables);
+
+            foreach ($noDataTables as $table) {
+                $command->addArg('--ignore-table', $opts['db'] . '.' . $table);
+            }
         }
         $command->addArg($opts['db']);
         $command->addArg(' > ', '', false);
@@ -365,11 +369,12 @@ public function actionDump()
         }
 
 
-        if ($noDataTables) {
+        if ($this->noDataTables) {
             // dump tables without data
             $commandNoData = CliHelper::getMysqlCommand('mysqldump', $db);
             $commandNoData->addArg('--no-tablespaces');
             $commandNoData->addArg('--no-data');
+            $commandNoData->addArg('--opt');
             $commandNoData->addArg($opts['db']);
 
             foreach ($noDataTables as $table) {