Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update finished function, issue-27 #78

Merged
merged 6 commits into from
Oct 13, 2023
Merged

update finished function, issue-27 #78

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
80a068f
update finished function, issue-27
sukhwinder-somar Aug 15, 2023
5c8b11b
check when page is null
sukhwinder-somar Sep 28, 2023
cf6a711
return null in loop
sukhwinder-somar Oct 1, 2023
56cef26
lint fixing
sukhwinder-somar Oct 9, 2023
6882b19
change inst to BaseElement instead of SiteTree
sukhwinder-somar Oct 9, 2023
43427d7
remove handling of null
sukhwinder-somar Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/Control/ElementFormController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use SilverStripe\Core\Injector\Injector;
use SilverStripe\UserForms\Control\UserDefinedFormController;
use SilverStripe\UserForms\Form\UserForm;
use SilverStripe\CMS\Model\SiteTree;

class ElementFormController extends ElementController
{
Expand Down Expand Up @@ -55,7 +56,19 @@ public function finished()
$user->finished();

$page = $this->getPage();
$controller = Injector::inst()->create($page->getControllerName(), $this->element->getPage());

if ($page === null) {
return null;
}

GuySartorelli marked this conversation as resolved.
Show resolved Hide resolved
while (!$page instanceof SiteTree) {
GuySartorelli marked this conversation as resolved.
Show resolved Hide resolved
$page = $page->getPage();
GuySartorelli marked this conversation as resolved.
Show resolved Hide resolved

if ($page === null) {
return null;
}
GuySartorelli marked this conversation as resolved.
Show resolved Hide resolved
}
$controller = Injector::inst()->create($page->getControllerName(), $page->data());
$element = $this->element;

return $controller->customise([
Expand Down