Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13 - added PlayerCharacter and related models #14

Merged
merged 8 commits into from
Jul 21, 2018
Merged

13 - added PlayerCharacter and related models #14

merged 8 commits into from
Jul 21, 2018

Conversation

ivellios
Copy link
Member

@ivellios ivellios commented Jul 16, 2018 •
edited
Loading

This Pull Request introduces changes from #13 and also from #11 and #9

Added:

  • PlayerCharacter model (and related races, classes and factions)
  • DMNotes model
  • admin interface for all models
  • login with email instead of username
  • username is nickname for the system
  • API endpoints (CRUD) - also for Profile and User
  • permissions: PlayerCharacter can be changed only by owners, but visible to any user
  • permissions: DMNotes can be seen by any DM, but modified only by owner
  • migration for profiles has been changed so dbs should be reseted

@ivellios ivellios self-assigned this Jul 16, 2018
@ivellios ivellios added the enhancement New feature or request label Jul 16, 2018
@ivellios ivellios added the backend This story touches backend label Jul 17, 2018
@ivellios
Copy link
Member Author

Looks like that's all for now. Ready for review :)

@ivellios ivellios added this to the v0.1 - MVP milestone Jul 17, 2018
@ivellios ivellios requested a review from DawidBydlosz July 21, 2018 07:27
DawidBydlosz
DawidBydlosz approved these changes Jul 21, 2018
View reviewed changes
Copy link

@DawidBydlosz DawidBydlosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and approved.

[relatedTo: 13 - added PlayerCharacter and related models #14]

DawidBydlosz
DawidBydlosz approved these changes Jul 21, 2018
View reviewed changes
Copy link

@DawidBydlosz DawidBydlosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 - added PlayerCharacter and related models #14

@ivellios ivellios merged commit 6be0035 into master Jul 21, 2018
@ivellios ivellios deleted the feature/13-models_for_characters branch July 21, 2018 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DawidBydlosz DawidBydlosz DawidBydlosz approved these changes

Assignees

@ivellios ivellios

Labels
backend This story touches backend enhancement New feature or request
Projects
None yet
Milestone
v0.1 - Backend MVP
Development

Successfully merging this pull request may close these issues.
2 participants
@ivellios @DawidBydlosz